ext/soap: Add test for Set-Cookie option parsing bug.#21400
Closed
devnexen wants to merge 3 commits intophp:PHP-8.4from
Closed
ext/soap: Add test for Set-Cookie option parsing bug.#21400devnexen wants to merge 3 commits intophp:PHP-8.4from
devnexen wants to merge 3 commits intophp:PHP-8.4from
Conversation
The cookie option parser uses a wrong offset to start scanning attributes, causing cookie values containing substrings like "path=" or "domain=" to be falsely matched as attributes.
- fix wrong cookie options offset calculation, using separator offset instead.
ndossche
requested changes
Mar 10, 2026
Member
ndossche
left a comment
ndossche
left a comment
There was a problem hiding this comment.
Nice find. Minor issue found though.
| char *sempos = strstr(cookie, ";"); | ||
| if (eqpos != NULL && (sempos == NULL || sempos > eqpos)) { | ||
| smart_str name = {0}; | ||
| int cookie_len; |
Member
There was a problem hiding this comment.
Removing this shadowed var is wrong: it will cause the loop advancement at line 1065 to be wrong: that line is supposed to skip the entire header value. Perhaps this shadowed variable should be renamed cookie_value_len.
ndossche
approved these changes
Mar 10, 2026
Member
ndossche
left a comment
ndossche
left a comment
There was a problem hiding this comment.
Looks right, I wonder how you found this though, it's rather subtle
Member
Author
|
I found it by accident while checking SOAP code, I did not notice at all at first until I debugged something a bit unrelated :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cookie option parser uses a wrong offset to start scanning attributes, causing cookie values containing substrings like "path=" or "domain=" to be falsely matched as attributes.